Introduce transcription protocol #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
approved these changes
Apr 27, 2024
theomonnom
reviewed
Apr 27, 2024
| @@ -117,6 +131,42 @@ async def publish_data( | |||
| if cb.publish_data.error: | |||
| raise PublishDataError(cb.publish_data.error) | |||
|
|
|||
| async def publish_transcription( | |||
| self, | |||
| participant_identity: str, | |||
There was a problem hiding this comment.
I would be more comfortable creating a Transcription structure here.
On the agents API, we will need to return a Transcription, and I don't think this should be defined inside agents.
publish_transcription accepting a "Transcription" seems OK to me
Also this will be needed for the "on_transcription_received" event
theomonnom
requested changes
Apr 27, 2024
| @@ -0,0 +1,10 @@ | |||
| from dataclasses import dataclass | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Add it here? (Transcription struct)
|
@theomonnom re: float. I think we should keep it int because the clock being used will be the frame clock. Although I'm wondering if we should specify units in the transcription protocol now: |
theomonnom
approved these changes
Apr 27, 2024
|
let's mb wait for a release tho? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.